add support in init script for using 'archdetect' alternative to archspec (only if $EESSI_USE_ARCHDETECT is set to '1')#187
Merged
boegel merged 57 commits intoEESSI:mainfrom Nov 8, 2022
Conversation
boegel
requested changes
Sep 15, 2022
boegel
requested changes
Sep 15, 2022
Contributor
|
@hmeiland I've gone through this PR one more time and it looks fine on my side. All I can think of as improvement at this point is to enhance the logging and comments in the script. I made the following changes in PR hmeiland#3:
You will see that the diff looks like I rewrote most of the script, but that's mainly because I standardize the indentation to 4 spaces. |
standarize log formatting by adding logging function
bartoldeman
suggested changes
Oct 3, 2022
boegel
requested changes
Nov 7, 2022
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
approved these changes
Nov 8, 2022
Contributor
|
I've tested this in various systems, works as expected:
I've also tested this on:
|
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Oct 7, 2023
{2023.06}[foss/2022a] add SciPy-bundle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative for archspec
not enabled by default: require EESSI_USE_ARCHDETECT to be used (for now)