flesh out script for checking on missing installations + fix it + test it in CI#218
Merged
trz42 merged 4 commits intoEESSI:mainfrom Jan 14, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
boegel
force-pushed
the
check_missing_installations_script
branch
from
3d39b99 to
cc15fd5
Compare
boegel
changed the title
Contributor
Author
trz42
requested changes
Jan 13, 2023
Collaborator
trz42
left a comment
trz42
left a comment
There was a problem hiding this comment.
Added a few comments for thought.
…OT_VERSION is set in check_missing_installations.sh
…nce $TMPDIR is a common environment variable (picked up by mktemp, etc.)
trz42
approved these changes
Jan 14, 2023
Collaborator
|
All suggested changes have been addressed. Thanks! |
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 16, 2024
…to_archspec switch back to using archspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a fix hidden here too: when running
eb --missing, we need to make sure that all easyconfig files are available, which currently requires using--from-pr 16531(because ofNextflow).New workflow to test
check_missing_installations.shscript works as expected, see https://github.com/boegel/software-layer/actions/runs/3914904116/jobs/6692747898