bot/build.sh using eessi_container.sh#233
Merged
boegel merged 37 commits intoEESSI:mainfrom Mar 17, 2023
Merged
Conversation
fixed bugs - determining IP address for proxy host was wrong - handling of positional parameters for executing commands with arguments was wrong
- added handling of HTTPS_PROXY - moved CONTAINER setting from site_config to repository section (different repositories could require different containers) - added handling of CPU_TARGET and EESSI_SOFTWARE_SUBDIR_OVERRIDE - updated TODOs - added setting of EESSI_REPOS_CFG_FILE_OVERRIDE - bug fixes
…/software-layer into enhancement/bot-build-with-swl-216
…nt/bot-build-with-swl-216
…ware-layer into enhancement/bot-build-with-eessi-container
cherry-picked via 23e773c Note only applied part for bot/build.sh
cherry-picked via bfb1b29 Note, only applied part for bot/build.sh
Contributor
…nt/bot-build-with-eessi-container
This was referenced Feb 25, 2023
trz42
changed the title
bot/build.sh using eessi_container.sh
boegel
reviewed
Mar 7, 2023
boegel
requested changes
Mar 7, 2023
This was referenced Mar 8, 2023
Contributor
|
Merging this, since it's ready, and so is EESSI/eessi-bot-software-layer#155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of the script to be called by the EESSI bot. Works with the updated script
eessi_container.sh(see #232).First version of
bot/build.sh.json&yqhave been replaced by a.cfg(.inifile format) &scripts/cfg_files.shrequires toolyqto parse.jsonfiles containing information from the bot to thebot/build.shyqis required where the bot jobs run (since it is a binary versions forx86_64andaarch64have to be installed)whileyqseems to be a nice tool, we may not want to depend on it and also not want to deal with different binaries; a possible change might require to not handover information in a.jsonfile but rather a simpler.inior.cfgfile and then use parsing functions provided byscripts/cfg_files.sh--generictoinstall_software_layer.shUpdates to
eessi_container.sheessi_container.shitself (improving output messages concerning--resumeinformation)--, e.g., can be calledBot-side code is added through EESSI/eessi-bot-software-layer#155