fix check for missing installations#237
Merged
boegel merged 12 commits intoEESSI:mainfrom Apr 11, 2023
Merged
Conversation
Collaborator
Author
|
Converted to a draft because it is only necessary if we use EB v4.7.0 or newer. |
Collaborator
Author
|
Changed script works for EB v4.5.1 (current latest EB version in EESSI pilot). Added a test that captures a missing package. The tests may fail if EB v4.7.0 or newer is used AND the format of the easystack file is not updated. |
boegel
requested changes
Apr 11, 2023
| grep " required modules missing:" ${eb_missing_out} > /dev/null | ||
|
|
||
| # we need to process the result (from finding `No missing modules` to NOT finding | ||
| # ` required modules missing:` and no other error happened) |
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 21, 2024
…i_container_script using pilot.nessi.no in testing eessi_container.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #236
Added comments to explain the needed change.
Should we add a test for this?