Skip to content

restore $PATH and $PYTHONPATH only after last run of pip installed eb#238

Merged
boegel merged 1 commit intoEESSI:mainfrom
trz42:fix_eb_not_found_error
Apr 11, 2023
Merged

restore $PATH and $PYTHONPATH only after last run of pip installed eb#238
boegel merged 1 commit intoEESSI:mainfrom
trz42:fix_eb_not_found_error

Conversation

@trz42
Copy link
Copy Markdown
Collaborator

@trz42 trz42 commented Mar 17, 2023

When starting a fresh software subdir, the eb command in

eb --search EasyBuild-${REQ_EB_VERSION}.eb | grep EasyBuild-${REQ_EB_VERSION}.eb > /dev/null
was not found because the PATH was restored too early. See
export PATH=${ORIG_PATH}
export PYTHONPATH=${ORIG_PYTHONPATH}

This PR moves these lines to after the if block.

It's been tested with ~ 2 PRs for NESSI starting fresh software subdirs.

The lines originated from #224

@eessi-bot
Copy link
Copy Markdown

eessi-bot Bot commented Mar 17, 2023

Instance bot-aws-PR155 is configured to build:

  • arch aarch64/graviton2 for repo EESSI-pilot
  • arch x86_64/generic for repo eessi-2021.12

Copy link
Copy Markdown
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title restore PATHs only after last run of pip installed eb restore $PATH and $PYTHONPATH only after last run of pip installed eb Apr 11, 2023
@boegel boegel merged commit 8346b6f into EESSI:main Apr 11, 2023
@trz42 trz42 deleted the fix_eb_not_found_error branch April 18, 2023 06:51
trz42 pushed a commit to trz42/software-layer that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants