only tar up software directories for which modules were generated#239
Merged
boegel merged 5 commits intoEESSI:mainfrom Apr 11, 2023
Merged
only tar up software directories for which modules were generated#239boegel merged 5 commits intoEESSI:mainfrom
boegel merged 5 commits intoEESSI:mainfrom
Conversation
|
Instance
|
boegel
requested changes
Mar 28, 2023
| find ${pilot_version}/software/${os}/${cpu_arch_subdir}/modules -type l | grep -v '/\.wh\.' >> ${files_list} | ||
| # module files and symlinks | ||
| find ${pilot_version}/software/${os}/${cpu_arch_subdir}/modules/all -type f -o -type l \ | ||
| | grep -v '/\.wh\.' | sed -e 's/.lua$//' | awk -F'/' '{printf "%s/%s\n", $(NF-1), $NF}' | sort | uniq \ |
Contributor
There was a problem hiding this comment.
avoid hardcoding standard EasyBuild module naming scheme by using sed 's@.*/modules/all/@@g'
use sort -u instead of sort | uniq
| # installation directories but only those for which module files were created | ||
| for package_version in $(cat ${module_files_list}); do | ||
| echo "handling ${package_version}" | ||
| ls -d ${pilot_version}/software/${os}/${cpu_arch_subdir}/software/${package_version} \ |
Contributor
There was a problem hiding this comment.
Add a comment here that the assumption here is that the module name and name of software installation directory match.
That will be the case as long as we use the standard EasyBuild module naming scheme, but will not be the case if we ever switch to another module naming scheme (like HierarchicalMNS)
trz42
pushed a commit
to trz42/software-layer
that referenced
this pull request
Jan 21, 2024
…ipts remove pilot from CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets
create_tarball.shonly include software directories for which module files have been created.It implements the first option in #225 (comment)
It has been tested interactively (resuming from a previous build job) and also in a bot job (NorESSI#57).
fixes #225