Allow archdetect to print all possible cpu paths + fix paths for aarch64/* (drop /arm/ subdir)#264
Merged
boegel merged 13 commits intoEESSI:mainfrom Nov 25, 2023
Merged
Conversation
Allow fix incorrect generic path
|
Instance
|
Member
Author
|
Addresses #261 (comment) |
boegel
requested changes
Sep 1, 2023
| case "$ARGUMENT" in | ||
| "cpupath") cpupath; exit;; | ||
| *) echo "$USAGE"; log "ERROR" "Missing <action> argument";; | ||
| "cpupath") cpupath $all; exit;; |
Contributor
There was a problem hiding this comment.
@ocaisa Rather than passing an argument to cpupath, I would make -a change the default value of a $CPUPATCH_RESULT from best to all, which matches better with what's done with $LOG_LEVEL?
| h) echo "$USAGE"; exit 0;; | ||
| d) LOG_LEVEL="DEBUG";; | ||
| v) echo "eessi_archdetect.sh v$VERSION"; exit 0;; | ||
| a) all="all";; |
Contributor
There was a problem hiding this comment.
Ideally we also have a constant like $CPUARCH_RESULT_ALL (where "cpuarch_result_all" is the value) than we can use for both setting and checking, to avoid bugs due to silly typos (I guess we should also try adding set -e so use of unset environment variables are treated like errors)
Member
Author
There was a problem hiding this comment.
Not quite sure what you mean here, but I think it is addressed in 7db0616
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
boegel
changed the title
archdetect to print all possible cpu pathsarchdetect to print all possible cpu paths + fix paths for aarch64/* (drop /arm/ subdir)
boegel
approved these changes
Nov 25, 2023
TopRichard
added a commit
to TopRichard/software-layer
that referenced
this pull request
Jan 31, 2024
….2.2-foss/2023a
{2023.06}[foss/2023a] BAGEL V1.2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix incorrect
genericpath.The idea with this PR is that if
archdetectprovides a full list of possible architecture matches. When used with a particularversionof EESSI, you could cycle through the list until you find a path that actually exists.It would allow us to keep
archdetectindependent of theversionand universally update it.