-
Notifications
You must be signed in to change notification settings - Fork 81
Fix failing test step on AWS #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trz42
merged 9 commits into
EESSI:2023.06-software.eessi.io
from
casparvl:fix_memory_detection_testsuite_aws
Aug 21, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
05c0b03
Make things more verbose, so we see where the memory limit comes from
1410707
More verobse
b24c30d
Of course, we should use the mounted dir /hostsys. It is entirely pos…
a53074e
get cpuset file from host as well
8b4e63b
Removed duplicate quote
6d19463
Apparently, bind-mounting the hosts /proc gives garbage, but reading …
c2b5535
Remove the bind-mind for /proc, it's not needed anymore
a860273
Cleanup debugging output
b82e183
Add clear description for why we use /hostsys
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path probably makes only sense if run in a very specific environment (e.g., testing software built for EESSI). While this is fine, how about checking whether
/sysor/hostsysis available and use that?If there would be a comment that explains what
/hostsysis and how it is made available, it might make debugging a little easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we bind-mount this additional path in
bot/test.sh. You're absolutely right about the commenting part: I'll make that clear.Regarding a fallback on
/sys, I'm not sure if we want to do that. If/hostsysisn't there, it means the bind-mount failed / was not executed. I'd probably prefer there to be a hard error, than a silent success here that maybe extracts the wrong amount of memory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, added the description now