Skip to content
This repository was archived by the owner on May 20, 2024. It is now read-only.

Update diceware.js#247

Merged
jsha merged 2 commits into
EFForg:masterfrom
sarciszewski:patch-1
Dec 4, 2014
Merged

Update diceware.js#247
jsha merged 2 commits into
EFForg:masterfrom
sarciszewski:patch-1

Conversation

@sarciszewski
Copy link
Copy Markdown
Contributor

Prevent whitespace bugs when parsing the PGP-signed wordlist. (I used this library separately in another project and ran head-first into this issue.)

Prevent whitespace bugs
@jsha
Copy link
Copy Markdown
Member

jsha commented Oct 6, 2014

I think \s*? isn't what you want. Normally ? marks an item as optional, but that would be redundant with the * operator since * can match zero characters. Additionally, ? has a special meaning when it comes after * or +. It means to do a non-greedy match, which is not necessary here because there's always going to be a digit afterwards.

I'd suggest replacing \s*? with \s*.

@sarciszewski
Copy link
Copy Markdown
Contributor Author

Err, yes. Wasn't paying super close attention there :)

sarciszewski added a commit to resonantcore/lib that referenced this pull request Oct 6, 2014
jsha added a commit that referenced this pull request Dec 4, 2014
@jsha jsha merged commit a1fdfb2 into EFForg:master Dec 4, 2014
@sarciszewski sarciszewski deleted the patch-1 branch December 6, 2014 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants