Run securecookie normalization script

@Hainish Please run this script: https://gist.github.com/koops76/14db6c6c1250eadc98644cff51e7add7.

I'm not making this a pull request because it changes 5354 files. Travis would probably explode. 😁

Please note that if ruleset whitelist cleanup is not run before running this script, it will throw errors on SHA256 mismatches.

After the script is run, merge #11872.

@Hainish Is <securecookie host="^\w" /> functionally equivalent to <securecookie host=".+" />?

[cschanaj]

@koops76 AFAIK

<securecookie host=".+" name=".+" />
                   ^         ^
     possibly some spaces here (some badly formated ones)
                                 ^
      this space does not necessarily exist, e.g. \s* should be better 

FYI, here is a sample regex used by hsts-prune for your reference. e.g

<securecookie\s+host=\s*['"]\^?\.[*+]?['"]\s+name=\s*['"]\^?\.[*+]?['"]\s*/>

And I recommend using a separate regex for each orders of name and host. It is much easier to read.

Not really, e.g. ^\w does not match .example.com but .+ does. Also, rules.js#L57 does not include ^\w.

@cschanaj Replaced \s+ with \s*.

[cschanaj]

@koops76 please also note the spaces before the quote and consider splitting the for each orders of name and host. thanks!!

@cschanaj Do you mean host= "something" or similar?

[cschanaj]

exactly. you can insert \s* right before the opening quotes.

@cschanaj Added whitespace after = support.

@cschanaj Can you try separating the regexes? I am not as good at regexes. This one was the most complex regex I made I guess. 😁

[cschanaj]

ok. A minor issues, the regex you use might rewrite commented securecookie as well. do you mind if I fix that as well? e.g.

<!-- <securecookie ... /> -->

Yeah, of course, do it. BTW, this is why parsing XML or HTML by regex is often a bad idea. 😁

[cschanaj]

@koops76 please have a look

• https://regex101.com/r/3oZTwt/1
• https://regex101.com/r/lcjFy4/1
• https://regex101.com/r/i0YO7Z/1

Source

• https://gist.github.com/cschanaj/eb0de61c00389cfccb93cd78381a7b8e

P.S. I seldom do nodejs but I guess this will work. (at least the regex 😄 )

[cschanaj]

Just updated to make sure host always go before name.

@cschanaj Why /.*/g instead of /.*/gi?

@cschanaj The first regex may match <securecookie host="." host="." /> or <securecookie name="." name="." />.