You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
The way I verified this was to manually check in a browser that the ^ subdomain for each ruleset, for example https://1177.se , supports HTTPS. It would be nice if there were some way to verify this without having to manually check.
Maybe you could modify your Go program to produce a Bash script that runs curl -I for each of the ^ subdomains, and then include these scripts in their corresponding PR. We can then verify that the list of domains in the script matches the list of domains modified in the PR and then run the script to check the network connection.
@jeremyn@J0WI I have modify the Go script to produce a list of target for each modified ruleset, and create a bash script to verify the list of target support HTTPS via curl -I, see cschanaj/trivialize-rules@af0d54e.
Be noted that #11019 and #11020 might require manual testing because the Go script used there is not compatible with the current one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11035