This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Update Coop.ch.xml #1188
Merged
Update Coop.ch.xml #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated domain
src/chrome/content/rules/Coop.ch.xml
Outdated
Member
There was a problem hiding this comment.
Change this to 'Needs ruleset tests' or remove it and add the necessary tests.
Contributor
Author
|
Finally! All tests passed. |
Member
|
There are a test url and a rule for www.coop.ch, but it is not included in the list of target hosts. Please remove them. This should have been caught by the checker, I filed an issue: https://github.com/hiviah/https-everywhere-checker/issues/ |
Contributor
Author
|
fixed |
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated domain