This repository was archived by the owner on Nov 6, 2023. It is now read-only.
[Drugcom.de] New ruleset #2585
Merged
[Drugcom.de] New ruleset #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @cypherpunk. You actually want '.' instead of '.' in your 'to'-attribute. The test fails because you should have trailing slashes in both 'to' and 'from' (so that 'drugcom.de' becomes 'drugcom.de/'). |
Contributor
Author
|
Thanks. Done. |
Contributor
|
LGTM. @fuglede Ping! |
Contributor
|
Thanks for the fix. This ruleset is actually not entirely good: the site does not serve a complete certificate chain which means that the user will be presented with a warning unless she has obtained the intermediate certificate via some other website (in which case the intermediate certificate might be stored). The SSL Labs test shows this error by indicating that the intermediate certificate is an "Extra download". |
Contributor
|
wfm now, merging |
Contributor
|
@semenko: It's still broken: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.