Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@numismatika
Copy link
Contributor

No description provided.

@J0WI
Copy link
Contributor

J0WI commented Feb 18, 2016

There is no host on www.idcdn.de

@numismatika
Copy link
Contributor Author

yea there isn't, just copied it from the alternative name field of the cert.

@J0WI
Copy link
Contributor

J0WI commented Feb 18, 2016

I wonder why this passed the tests @fuglede @jsha

@fuglede
Copy link
Contributor

fuglede commented Feb 18, 2016

@J0WI: Because a run of https-everywhere-checker would have caused the issue, you mean? Adding such tests on a by-PR basis is the content of #3107.

@J0WI
Copy link
Contributor

J0WI commented Feb 18, 2016

fetch-test.sh exposed the issue:

$ ./fetch-test.sh rules/IppenDigital.xml 
INFO Finished comparing http://idcdn.de/ -> https://idcdn.de/. Rulefile: rules/IppenDigital.xml.
INFO Finished comparing http://www.idcdn.de/ -> https://www.idcdn.de/. Rulefile: rules/IppenDigital.xml.
ERROR rules/IppenDigital.xml: Fetch error: http://www.idcdn.de/ => https://www.idcdn.de/: (6, 'Could not resolve host: www.idcdn.de')
INFO Finished in 1.30 seconds. Loaded rulesets: 1, URL pairs: 2.

@numismatika
Copy link
Contributor Author

@J0WI second commit removes that host

J0WI added a commit that referenced this pull request Feb 19, 2016
add rule for Ippen Digital
@J0WI J0WI merged commit b8b9456 into EFForg:master Feb 19, 2016
@numismatika numismatika deleted the ID branch February 19, 2016 18:44
@numismatika numismatika restored the ID branch February 27, 2016 09:50
@numismatika numismatika deleted the ID branch February 27, 2016 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants