Skip to content

Fix preview version names in release process.#108

Merged
koenbeuk merged 1 commit intoEFNext:masterfrom
ZvonimirMatic:master
Jun 12, 2024
Merged

Fix preview version names in release process.#108
koenbeuk merged 1 commit intoEFNext:masterfrom
ZvonimirMatic:master

Conversation

@ZvonimirMatic
Copy link
Copy Markdown
Contributor

In release action, remove 'v' only from the beginning of the version. Currently it's removing all letters 'v' from the version so v4.0.0-preview.2 is published as 4.0.0-preiew.2.

Found the solution using Chat GPT and this StackOverflow post: https://stackoverflow.com/questions/71630227/github-action-how-to-remove-starting-v-from-variable

Can't really test it, hopefully it works.

Closes #106.

@rmunn
Copy link
Copy Markdown

rmunn commented Jun 13, 2024

Variable substitution in Bash is documented here. The # syntax deletes the shortest matching pattern from the beginning of the variable (and ## deletes the longest matching pattern instead). Here there's only one pattern (v) and it's one character long, so the shortest/longest distinction shouldn't matter. So yes, based on my knowledge of Bash syntax, this looks correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NuGet packages named "preiew" instead of "preview"

3 participants