Add support for pattern matching in various cases

src/EntityFrameworkCore.Projectables.Generator/AnalyzerReleases.Unshipped.md

@@ -1 +1,6 @@
-
+### New Rules
+
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-----------------------------------------------
+EFP0007 | Design   | Error    | Unsupported pattern in projectable expression
+

src/EntityFrameworkCore.Projectables.Generator/Diagnostics.cs

@@ -52,5 +52,13 @@ public static class Diagnostics
             DiagnosticSeverity.Error,
             isEnabledByDefault: true);
 
+        public static readonly DiagnosticDescriptor UnsupportedPatternInExpression = new DiagnosticDescriptor(
+            id: "EFP0007",
+            title: "Unsupported pattern in projectable expression",
+            messageFormat: "The pattern '{0}' cannot be rewritten into an expression tree. Simplify the pattern or restructure the projectable member body.",
+            category: "Design",
+            DiagnosticSeverity.Error,
+            isEnabledByDefault: true);
+
     }
 }

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithAndPattern.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_IsInRange_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity.Value >= 1 && entity.Value <= 100 ? true : false;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithConstantPattern.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_IsNull_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity == null ? true : false;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithNotPattern.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_IsNotNull_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity entity) => !(entity == null) ? true : false;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithOrPattern.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_IsTerminal_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity.Status == "Cancelled" || entity.Status == "Completed" ? true : false;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithPatternMatching.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_GetComplexCategory_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity != null && entity.IsActive == true && entity.Value > 100 ? "Active High" : "Other";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.BlockBodiedMethod_WithRelationalPattern.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_GetCategory_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity.Value > 100 ? "High" : "Low";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExpressionBodied_IsPattern_WithAndPattern.verified.txt

@@ -0,0 +1,16 @@
+// <auto-generated/>
+#nullable disable
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Entity_IsInRange
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Value >= 1 && @this.Value <= 100;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExpressionBodied_IsPattern_WithNotNullPattern.verified.txt

@@ -0,0 +1,16 @@
+// <auto-generated/>
+#nullable disable
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Entity_HasName
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity @this) => !(@this.Name == null);
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExpressionBodied_IsPattern_WithOrPattern.verified.txt

@@ -0,0 +1,16 @@
+// <auto-generated/>
+#nullable disable
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Entity_IsOutOfRange
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Value == 0 || @this.Value > 100;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExpressionBodied_IsPattern_WithPropertyPattern.verified.txt

@@ -0,0 +1,16 @@
+// <auto-generated/>
+#nullable disable
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Extensions_IsActiveAndPositive_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity entity) => entity != null && entity.IsActive == true && entity.Value > 0;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberOnInterface.DotNet10_0.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_IEntityExtensions_Label
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.IEntity, string>> Expression()
+        {
+            return (global::Foo.IEntity @this) => @this.Id + ": " + @this.Name;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberOnInterface.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_IEntityExtensions_Label
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.IEntity, string>> Expression()
+        {
+            return (global::Foo.IEntity @this) => @this.Id + ": " + @this.Name;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithBlockBody.DotNet10_0.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_GetStatus_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.IsActive && @this.Value > 0 ? "Active" : "Inactive";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithBlockBody.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_GetStatus_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.IsActive && @this.Value > 0 ? "Active" : "Inactive";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithIsPatternExpression.DotNet10_0.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_IsHighValue
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Value > 100;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithIsPatternExpression.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_IsHighValue
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, bool>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Value > 100;
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithSwitchExpression.DotNet10_0.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_GetGrade_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Score >= 90 ? "A" : @this.Score >= 80 ? "B" : @this.Score >= 70 ? "C" : "F";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.ExtensionMemberWithSwitchExpression.verified.txt

@@ -0,0 +1,17 @@
+// <auto-generated/>
+#nullable disable
+using System;
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_EntityExtensions_GetGrade_P0_Foo_Entity
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Score >= 90 ? "A" : @this.Score >= 80 ? "B" : @this.Score >= 70 ? "C" : "F";
+        }
+    }
+}

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.SwitchExpressionWithTypePattern.verified.txt

@@ -9,7 +9,7 @@ namespace EntityFrameworkCore.Projectables.Generated
     {
         static global::System.Linq.Expressions.Expression<global::System.Func<global::Item, global::ItemData>> Expression()
         {
-            return (global::Item item) => item.GetType() == typeof(GroupItem) ? new global::GroupData(((GroupItem)item).Id, ((GroupItem)item).Name, ((GroupItem)item).Description) : item.GetType() == typeof(DocumentItem) ? new global::DocumentData(((DocumentItem)item).Id, ((DocumentItem)item).Name, ((DocumentItem)item).Priority) : null !;
+            return (global::Item item) => item is GroupItem ? new global::GroupData(((GroupItem)item).Id, ((GroupItem)item).Name, ((GroupItem)item).Description) : item is DocumentItem ? new global::DocumentData(((DocumentItem)item).Id, ((DocumentItem)item).Name, ((DocumentItem)item).Priority) : null !;
         }
     }
 }

tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.SwitchExpression_WithRelationalPattern.verified.txt

@@ -0,0 +1,16 @@
+// <auto-generated/>
+#nullable disable
+using EntityFrameworkCore.Projectables;
+using Foo;
+
+namespace EntityFrameworkCore.Projectables.Generated
+{
+    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
+    static class Foo_Entity_GetGrade
+    {
+        static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.Entity, string>> Expression()
+        {
+            return (global::Foo.Entity @this) => @this.Score >= 90 ? "A" : @this.Score >= 80 ? "B" : @this.Score >= 70 ? "C" : "F";
+        }
+    }
+}