Add support for interfaces in generic methods#57
Merged
koenbeuk merged 2 commits intoEFNext:masterfrom Jan 15, 2023
Merged
Conversation
added 2 commits
January 11, 2023 14:08
Change overriding member logic to use MethodInfo.GetBaseDefinition()
…in a member expression
Collaborator
|
Awesome! I'll review this tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, an expression in a generic method that references an interface member can be translated as long as the runtime generic argument is a concrete type. For example:
Here, when
SelectComputedPropertyis called likeSelectComputedProperty<InheritedModelTests.Concrete>(where the argument can be implicit like in InheritedModelTests.cs), the correct implementation method can be found inConcrete.However, when it is called like
SelectComputedProperty<InheritedModelTests.IBase>, the concrete implementation is unknown and the method can't be translated.I also changed overriding member logic (from #52) to use
MethodInfo.GetBaseDefinition()instead of the name and signature of the method.I changed some tests, because there were two duplicate tests in InheritedModelTests.cs. I assumed these modifications were the original intention.
Possible improvements:
Thanks for creating and maintaining this package!