Add modified reinhard support#30
Conversation
|
Hi, I am finally back from vacation. I am merging all the pending PR, however I see some tests are failing due to |
|
For Modified Reinhard, nice work. I was thinking maybe of refactoring it using a sublcass ModifiedReinhardNormalizer rather than the |
Definitely. I just did not observe that on my local testing setup, as I was using an older numpy version. Using
That was actually my first suggestion, but then I realized how extremely similar the two variants were, and I thought having a method flag makes more sense. But up to you :] EDIT: |
|
Okay, let's keep the method argument for now. Yes, I will merge everything onto the development branch and then I will fix the numpy tests |
This PR extends Reinhard and adds a new method argument, which enables the user to choose between traditional Reinhard and the Modified version. All backends supported.
This PR can be merged after #27 , as this branch was based on that branch.