Refactor: minor README improvements + code syntax adjustments#35
Merged
carloalbertobarbano merged 3 commits intoEIDOSLAB:developmentfrom May 25, 2023
Merged
Refactor: minor README improvements + code syntax adjustments#35carloalbertobarbano merged 3 commits intoEIDOSLAB:developmentfrom
carloalbertobarbano merged 3 commits intoEIDOSLAB:developmentfrom
Conversation
…o runtimes in backend comparison [no ci]
Collaborator
Author
|
Otherwise, I believe this branch can be merged and a new release can be made. Jax backend support, as well as support for the vahadane algorithm can be made in the future. Not feasible to add for this release. |
andreped
changed the title
Collaborator
Author
|
@carloalbertobarbano Note that I have improved documentations in this PR. We have also added support for modified reinhard, which was not documented in the existing README. Also, what about JAX support? Vahadane is not ready to be added, but I believe the Macenko with JAX support should be ready, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications to the README:
Modifications to the code: