Skip to content

Speed optimizations#39

Merged
carloalbertobarbano merged 11 commits intoEIDOSLAB:developmentfrom
ajinkya-kulkarni:patch-1
May 5, 2023
Merged

Speed optimizations#39
carloalbertobarbano merged 11 commits intoEIDOSLAB:developmentfrom
ajinkya-kulkarni:patch-1

Conversation

@ajinkya-kulkarni
Copy link
Contributor

Using slicing and indexing to extract the L, a, and b channels from the input array, and perform the necessary operations using broadcasting. This allows eliminating the need for explicit loops, improving the performance of the function.

andreped and others added 9 commits December 3, 2022 21:08
Using slicing and indexing to extract the L, a, and b channels from the input array, and perform the necessary operations using broadcasting. 
This allows eliminating the need for explicit loops, improving the performance of the function.
@carloalbertobarbano
Copy link
Member

carloalbertobarbano commented Apr 3, 2023

Hi, thanks for your contribution. I updated the workflows in the main branch (they were using a deprecated version of ubuntu). Can you update your branches with the correct workflows so that I can run the unit tests?

@andreped
Copy link
Collaborator

@carloalbertobarbano this PR now runs CIs with ubuntu-20.04. Can you approve the workflow to be run, such that we can test that everything is in order? If yes, we can add the same fix to the two remaining PRs @ajinkya-kulkarni made.

@andreped
Copy link
Collaborator

I had forgotten to use ubuntu-20.04 for a pytorch test. However, I have done that now. Also applied the same fixes to all three PRs @ajinkya-kulkarni made. However, just waiting for my PRs to his fork to be merged. If so, then I believe tests could be ran.

@ajinkya-kulkarni
Copy link
Contributor Author

I have synced my fork! Sorry for the delay.

@andreped
Copy link
Collaborator

andreped commented Apr 26, 2023

I have synced my fork! Sorry for the delay.

@ajinkya-kulkarni No worries. You have to sync the individual branches as well, not just the main branch. Thats what my PRs to your fork do.

@carloalbertobarbano carloalbertobarbano changed the base branch from main to development May 5, 2023 10:32
@carloalbertobarbano
Copy link
Member

All checks passed. Merging into development

@carloalbertobarbano carloalbertobarbano merged commit a472027 into EIDOSLAB:development May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants