Tenant code filter added to organization/read internal api

[adithyadinesh0412]

Summary by CodeRabbit

• New Features
  • Enhanced organization lookup to support filtering by tenant code in addition to existing parameters. This allows for more precise retrieval of organization details based on tenant information.

[coderabbitai]

Walkthrough

The Organization controller's read method and the OrganizationsHelper.read service method were updated to support an additional tenant_code parameter. The controller now forwards tenant_code from the request query to the service, which uses it to further filter organizations when retrieving details.

Changes

Cohort / File(s)	Change Summary
Controller Update src/controllers/v1/organization.js	Modified the read method to extract tenant_code from request query and pass it to the service layer.
Service Update src/services/organization.js	Updated OrganizationsHelper.read to accept and use tenantCode for filtering organizations.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Controller (Organization)
    participant Service (OrganizationsHelper)
    Client->>Controller (Organization): GET /organization?organisation_id&organisation_code&tenant_code
    Controller (Organization)->>Service (OrganizationsHelper): read(organisationId, organisationCode, tenantCode)
    Service (OrganizationsHelper)-->>Controller (Organization): Organization data (filtered)
    Controller (Organization)-->>Client: Response with organization data

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A tenant code hops in, what a treat,
Now orgs are filtered, oh so neat!
With queries more clever,
And logic more tight,
This bunny’s code leaps to a brand-new height.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e13d2e1 and 32ea386.

📒 Files selected for processing (2)

• src/controllers/v1/organization.js (1 hunks)
• src/services/organization.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/services/**

⚙️ CodeRabbit Configuration File

This is core business logic. Please check for correctness, efficiency, and potential edge cases.

Files:

• src/services/organization.js

src/controllers/**

⚙️ CodeRabbit Configuration File

These are API controllers. Focus on request/response handling, security (auth middleware usage), and proper status codes.

Files:

• src/controllers/v1/organization.js

🧠 Learnings (3)

📓 Common learnings

Learnt from: nevil-mathew
PR: ELEVATE-Project/user#776
File: src/services/entities.js:18-23
Timestamp: 2025-07-31T08:44:36.982Z
Learning: In the ELEVATE-Project/user codebase, organizationCode and tenantCode parameters passed to service methods always come from req.decodedToken.organization_code and req.decodedToken.tenant_code, which are guaranteed to be present after token validation. Additional validation for these parameters in service methods is unnecessary as the token validation process ensures they are always available.

Learnt from: nevil-mathew
PR: ELEVATE-Project/user#776
File: src/database/models/entityType.js:38-38
Timestamp: 2025-07-31T08:43:35.971Z
Learning: The migration for converting tenant_code to a primary key in the EntityType model was already handled in a previous PR, not in the current refactoring PR that focuses on organization codes instead of organization IDs.

📚 Learning: in the elevate-project/user codebase, organizationcode and tenantcode parameters passed to service m...

Learnt from: nevil-mathew
PR: ELEVATE-Project/user#776
File: src/services/entities.js:18-23
Timestamp: 2025-07-31T08:44:36.982Z
Learning: In the ELEVATE-Project/user codebase, organizationCode and tenantCode parameters passed to service methods always come from req.decodedToken.organization_code and req.decodedToken.tenant_code, which are guaranteed to be present after token validation. Additional validation for these parameters in service methods is unnecessary as the token validation process ensures they are always available.

Applied to files:

• src/services/organization.js
• src/controllers/v1/organization.js

📚 Learning: the migration for converting tenant_code to a primary key in the entitytype model was already handle...

Learnt from: nevil-mathew
PR: ELEVATE-Project/user#776
File: src/database/models/entityType.js:38-38
Timestamp: 2025-07-31T08:43:35.971Z
Learning: The migration for converting tenant_code to a primary key in the EntityType model was already handled in a previous PR, not in the current refactoring PR that focuses on organization codes instead of organization IDs.

Applied to files:

• src/services/organization.js
• src/controllers/v1/organization.js

🔇 Additional comments (2)

src/services/organization.js (1)

402-410: LGTM! Tenant code filtering implemented correctly.

The implementation properly:

• Adds optional tenantCode parameter with backward compatibility
• Only applies tenant filtering when searching by organization code (not ID)
• Uses trim() to handle whitespace appropriately
• Maintains existing logic flow

src/controllers/v1/organization.js (1)

156-157: LGTM! Controller properly extracts tenant_code parameter.

The implementation correctly:

• Extracts tenant_code from query parameters
• Provides appropriate empty string fallback
• Maintains consistency with existing parameter handling pattern
• Passes parameters in correct order to service method

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.