Skip to content

scp packages version changes#373

Merged
priyanka-TL merged 4 commits intomasterfrom
scp_package
Nov 6, 2025
Merged

scp packages version changes#373
priyanka-TL merged 4 commits intomasterfrom
scp_package

Conversation

@praveenKDass
Copy link
Copy Markdown
Collaborator

@praveenKDass praveenKDass commented Oct 30, 2025

Summary by CodeRabbit

  • New Features

    • Added two POST endpoints for configuration creation/update and for updating related organizations to improve configuration management.
  • Chores

    • Bumped package version to 1.0.68.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Added two POST route mappings to the portal's routes config for config operations (/scp/v1/config/createOrUpdate and /scp/v1/config/updateRelatedOrgs) and bumped the package version from 1.0.67 to 1.0.68.

Changes

Cohort / File(s) Summary
Route Configuration Updates
elevate-self-creation-portal/constants/routes.js
Added two new POST route mappings: sourceRoute: '/scp/v1/config/createOrUpdate' and sourceRoute: '/scp/v1/config/updateRelatedOrgs', both with inSequence: false and orchestrated: false, targeting equivalent POST paths.
Package Version
elevate-self-creation-portal/package.json
Updated package version from 1.0.67 to 1.0.68. No other changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Client
    participant Gateway as API Gateway (routes.js)
    participant Backend as Target Service

    Client->>Gateway: POST /scp/v1/config/createOrUpdate
    Note right of Gateway: inSequence: false<br/>orchestrated: false
    Gateway->>Backend: POST /scp/v1/config/createOrUpdate
    Backend-->>Gateway: 200/4xx
    Gateway-->>Client: 200/4xx

    Client->>Gateway: POST /scp/v1/config/updateRelatedOrgs
    Note right of Gateway: inSequence: false<br/>orchestrated: false
    Gateway->>Backend: POST /scp/v1/config/updateRelatedOrgs
    Backend-->>Gateway: 200/4xx
    Gateway-->>Client: 200/4xx
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check exact path spelling and HTTP method consistency in routes.js.
  • Verify there are no conflicting route entries.
  • Confirm version bump in package.json aligns with release process.

Possibly related PRs

  • scp packages version changes #373 — Adds the same sourceRoute entries (/scp/v1/config/createOrUpdate, /scp/v1/config/updateRelatedOrgs) to routes.js but with different targetRoute values; likely related and may conflict.

Suggested reviewers

  • VISHNUDAS-tunerlabs

Poem

🐰 New paths in springtime code I sow,
Two little hops where POSTs can go,
Create and update, quick and light,
Version bumped — the build takes flight,
A rabbit cheers the routes just so. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'scp packages version changes' is vague and generic. The actual changes are two new route mappings added to the routes configuration file, not package version updates. Use a more specific title that reflects the actual changes, such as 'Add config route mappings for createOrUpdate and updateRelatedOrgs' or similar that describes the route additions.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26c8d94 and 0bc9a96.

📒 Files selected for processing (1)
  • elevate-self-creation-portal/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0dba3f4 and c54f1d8.

📒 Files selected for processing (2)
  • elevate-self-creation-portal/constants/routes.js (1 hunks)
  • elevate-self-creation-portal/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-05T09:46:50.071Z
Learnt from: MallanagoudaB
PR: ELEVATE-Project/utils#329
File: elevate-project/constants/routes.js:0-0
Timestamp: 2025-08-05T09:46:50.071Z
Learning: In the elevate-project/constants/routes.js file, the `orchestrated` property is not compulsory for all route configurations. Out of 293 total routes, 33 routes (about 11%) exist without this property, making it optional rather than required.

Applied to files:

  • elevate-self-creation-portal/constants/routes.js
📚 Learning: 2025-08-05T09:46:50.071Z
Learnt from: MallanagoudaB
PR: ELEVATE-Project/utils#329
File: elevate-project/constants/routes.js:0-0
Timestamp: 2025-08-05T09:46:50.071Z
Learning: In the elevate-project/constants/routes.js file, the `orchestrated` property is not compulsory for all route configurations. Many routes exist without this property, making it optional rather than required.

Applied to files:

  • elevate-self-creation-portal/constants/routes.js
📚 Learning: 2025-08-05T09:46:07.320Z
Learnt from: MallanagoudaB
PR: ELEVATE-Project/utils#329
File: elevate-project/constants/routes.js:0-0
Timestamp: 2025-08-05T09:46:07.320Z
Learning: In route configuration files like elevate-project/constants/routes.js, the `orchestrated` property is optional and not required for all endpoints. Some routes have `orchestrated: false` while others omit this property entirely.

Applied to files:

  • elevate-self-creation-portal/constants/routes.js
📚 Learning: 2025-08-05T09:46:00.231Z
Learnt from: MallanagoudaB
PR: ELEVATE-Project/utils#329
File: elevate-project/constants/routes.js:3128-3137
Timestamp: 2025-08-05T09:46:00.231Z
Learning: In route configurations for the ELEVATE project, the `orchestrated` property is not mandatory for all endpoints. Some routes explicitly set `orchestrated: false`, some omit the property entirely, and some set it to `true` (typically when `inSequence: true` is also set for interface routes). The presence or absence of the `orchestrated` property depends on the specific requirements of each route.

Applied to files:

  • elevate-self-creation-portal/constants/routes.js
🔇 Additional comments (1)
elevate-self-creation-portal/package.json (1)

3-3: LGTM! Standard version bump.

The patch version increment from 1.0.65 to 1.0.66 is appropriate for adding new route mappings.

@priyanka-TL priyanka-TL merged commit f5181a9 into master Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants