-
Notifications
You must be signed in to change notification settings - Fork 0
feat(api): add Prometheus metrics endpoint #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
82eb65a
feat(api): add Prometheus metrics endpoint
pescn af35f8e
feat(metrics): enhance Prometheus metrics with rate limit tracking an…
pescn f231255
fix(metrics): handle /metrics/ trailing slash to prevent SPA fallback
pescn 9eae9aa
fix(metrics): address code review feedback
pescn 5e5675b
refactor(metrics): address code review feedback from koitococo
pescn cef8036
fix(metrics): handle /metrics/ trailing slash to prevent SPA fallback
pescn 91bce92
refactor(db): use single query for getActiveEntityCounts
pescn ad24e3c
merge: bring in bun.lock internal registry fix from main
pescn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { Elysia } from "elysia"; | ||
| import { generatePrometheusMetrics } from "@/services/prometheus"; | ||
|
|
||
| /** | ||
| * Prometheus metrics endpoint | ||
| * Exposes operational metrics in Prometheus exposition format | ||
| * | ||
| * SECURITY NOTE: This endpoint is intentionally public (no authentication required). | ||
| * This is a deliberate design choice because: | ||
| * | ||
| * 1. Standard Practice: Prometheus metrics endpoints are typically unauthenticated | ||
| * to allow easy scraping by monitoring systems. | ||
| * | ||
| * 2. Operational Data Only: The metrics expose only aggregated operational data | ||
| * (request counts, latencies, token usage, error rates). No sensitive data | ||
| * like API keys, request/response content, or user data is exposed. | ||
| * | ||
| * 3. API Key Privacy: The `api_key_comment` label is used instead of the actual | ||
| * API key value, providing meaningful aggregation without exposing secrets. | ||
| * | ||
| * 4. Network Security: In production deployments, network-level security (firewall | ||
| * rules, VPC, ingress policies) should restrict access to the metrics endpoint | ||
| * to authorized monitoring systems only. | ||
| * | ||
| * If stricter security is required, consider: | ||
| * - Using network policies to restrict access to Prometheus scrapers | ||
| * - Deploying a metrics proxy with authentication | ||
| * - Adding optional bearer token authentication via environment variable | ||
| */ | ||
| export const metricsApi = new Elysia().get( | ||
| "/metrics", | ||
| async () => { | ||
| const metrics = await generatePrometheusMetrics(); | ||
| return new Response(metrics, { | ||
| headers: { | ||
| "Content-Type": "text/plain; version=0.0.4; charset=utf-8", | ||
| }, | ||
| }); | ||
| }, | ||
| { | ||
| detail: { | ||
| description: | ||
| "Prometheus metrics endpoint. Returns operational metrics in Prometheus exposition format.", | ||
| tags: ["Metrics"], | ||
| }, | ||
| }, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.