Coordinates droped in filter_dataset method#43
Merged
Conversation
forman
requested changes
Apr 15, 2025
| from typing import Iterable | ||
|
|
||
| import xarray as xr | ||
| from dask.core import keys_in_tasks |
Collaborator
Author
There was a problem hiding this comment.
OK I see. I tested stuff in the code, and this was added automatically..
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
forman
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Dropping respective coordinates is already handled by
name_filter.filter(names)in https://github.com/EOPF-Sample-Service/xarray-eopf/blob/main/xarray_eopf/filter.py#L20