explicitly destroying io_serv at the end of shutdown#7
Merged
Conversation
when the io_serv is stopped it may still own std::functions/lambdas that have captured data in them. If this captured data relies on another system like a logging system, for instance, waiting for destructors to be called by the atexit call may result in them accessing a destroyed system. By explicitly resetting the io_serve after shutdown we in turn release any resources it has while the systems are still alive and well
heifner
approved these changes
Nov 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the io_serv is stopped it may still own std::functions/lambdas that have captured data in them. If this captured data relies on another system like a logging system, for instance, waiting for destructors to be called by the atexit call may result in them accessing a destroyed system. By explicitly resetting the io_serve after shutdown we in turn release any resources it has while the systems are still alive and well