Skip to content

Remove semicolon disabling logconf option. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgiszczak merged 2 commits into from
Nov 30, 2017
Merged

Remove semicolon disabling logconf option. #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cf6f43
Remove semicolon disabling logconf option.
jgiszczak Nov 30, 2017
770392a
Default logging filename. Command line is parsed very late.
jgiszczak Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class application_impl {
options_description _cfg_options;

bfs::path _data_dir;
bfs::path _logging_conf;
bfs::path _logging_conf{"logging.json"};

uint64_t _version;
};
Expand Down Expand Up @@ -82,7 +82,7 @@ void application::set_program_options()
("help,h", "Print this help message and exit.")
("version,v", "Print version information.")
("data-dir,d", bpo::value<bfs::path>()->default_value( "data-dir" ), "Directory containing configuration file config.ini")
("config,c", bpo::value<bfs::path>()->default_value( "config.ini" ), "Configuration file name relative to data-dir");
("config,c", bpo::value<bfs::path>()->default_value( "config.ini" ), "Configuration file name relative to data-dir")
("logconf,l", bpo::value<bfs::path>()->default_value( "logging.json" ), "Logging configuration file name/path for library users");

my->_cfg_options.add(app_cfg_opts);
Expand Down