This repository was archived by the owner on Aug 2, 2022. It is now read-only.
#864 fix reconnection sync crash and bump the sync fetch span to 100 …#880
Merged
#864 fix reconnection sync crash and bump the sync fetch span to 100 …#880
Conversation
Contributor
Author
|
note my editor is set to nuke trailing whitespace |
heifner
reviewed
Dec 6, 2017
| out_queue.clear(); | ||
| if(response_expected) { | ||
| response_expected->cancel(); | ||
| response_expected.reset(); |
Contributor
There was a problem hiding this comment.
This was added by: PR #831 .
Should it instead be:
response_expected.reset(new boost::asio::steady_timer(app().get_io_service()));
Contributor
Author
There was a problem hiding this comment.
no, I am simply not getting rid of the current timer instance.
heifner
approved these changes
Dec 6, 2017
spoonincode
pushed a commit
that referenced
this pull request
Dec 8, 2017
(repaplied on noon branch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…blocks