Task 2: Deploy app to S3 & CloudFront#556
Open
ShruteePimpare wants to merge 3 commits intoEPAM-JS-Competency-center:mainfrom
Open
Task 2: Deploy app to S3 & CloudFront#556ShruteePimpare wants to merge 3 commits intoEPAM-JS-Competency-center:mainfrom
ShruteePimpare wants to merge 3 commits intoEPAM-JS-Competency-center:mainfrom
Conversation
the-rodz
reviewed
Apr 24, 2025
|
|
||
| /* Uncomment the next line if you know exactly what Account and Region you | ||
| * want to deploy the stack to. */ | ||
| env: { account: '888577065334', region: 'ap-south-1' }, |
There was a problem hiding this comment.
Wondering if that'd be a better aproach to provide values for account and region as an env variables? What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CDK infra for S3 + CloudFront distribution. Includes SPA hosting setup and bucket policy for public access.