Skip to content

Replace command line parsing library for Cpp11#2211

Merged
galabovaa merged 9 commits intolatestfrom
cmd-opts
Mar 7, 2025
Merged

Replace command line parsing library for Cpp11#2211
galabovaa merged 9 commits intolatestfrom
cmd-opts

Conversation

@galabovaa
Copy link
Copy Markdown
Contributor

cxxopts upgrade introduced one line from C++17 causing warnings.
CLI11 is only C++11

@galabovaa galabovaa requested a review from jajhall March 7, 2025 10:08
Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 47.22222% with 76 lines in your changes missing coverage. Please review.

Project coverage is 78.79%. Comparing base (17928bb) to head (fee8e64).
Report is 15 commits behind head on latest.

Files with missing lines Patch % Lines
app/HighsRuntimeOptions.h 51.81% 53 Missing ⚠️
app/RunHighs.cpp 32.35% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2211   +/-   ##
=======================================
  Coverage   78.78%   78.79%           
=======================================
  Files         343      343           
  Lines       83012    83001   -11     
=======================================
- Hits        65404    65400    -4     
+ Misses      17608    17601    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa galabovaa merged commit c40c0b4 into latest Mar 7, 2025
@galabovaa galabovaa mentioned this pull request Mar 7, 2025
@galabovaa galabovaa deleted the cmd-opts branch March 24, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants