Skip to content

Include cmake bux fix#2253

Merged
galabovaa merged 2 commits intolatestfrom
include-cmake
Mar 25, 2025
Merged

Include cmake bux fix#2253
galabovaa merged 2 commits intolatestfrom
include-cmake

Conversation

@galabovaa
Copy link
Copy Markdown
Contributor

@galabovaa galabovaa commented Mar 24, 2025

closes #2250

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (d5099ea) to head (a6f6015).
Report is 7 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2253   +/-   ##
=======================================
  Coverage   78.93%   78.94%           
=======================================
  Files         343      343           
  Lines       83419    83419           
=======================================
+ Hits        65850    65851    +1     
+ Misses      17569    17568    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@galabovaa galabovaa merged commit 58a9fd1 into latest Mar 25, 2025
276 checks passed
@Mizux
Copy link
Copy Markdown
Contributor

Mizux commented Mar 31, 2025

one question:
while you move the call containing ${CMAKE_CUDA_PATH}/... to avoid it to be empty and thus having an absolute path

Why you didn't use the idiomatic $<BUILD_INTERFACE:${CMAKE_CUDA_PATH}/...> construction instead ?

i.e. never use target include PUBLIC without the generator expression $<BUILD_INTERFACE:> $<INSTALL_INTERFACE:>...
ref: https://cmake.org/cmake/help/latest/command/target_include_directories.html#creating-relocatable-packages

@galabovaa
Copy link
Copy Markdown
Contributor Author

Thank you @Mizux I will add $<BUILD_INTERFACE:> in another PR

@galabovaa galabovaa mentioned this pull request Apr 8, 2025
@galabovaa galabovaa deleted the include-cmake branch April 16, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants