Skip to content

CLI11 fix spaces#2387

Merged
galabovaa merged 3 commits intolatestfrom
cli-fix-spaces
Jun 4, 2025
Merged

CLI11 fix spaces#2387
galabovaa merged 3 commits intolatestfrom
cli-fix-spaces

Conversation

@galabovaa
Copy link
Copy Markdown
Contributor

Closes #2385

CLI11 handles multiple files with

catch (const CLI::ExtrasError& e) 

and

catch (const CLI::ArgumentMismatch& e) 

in RunHighs.cpp, so checkSingle is not required in HighsRuntimeOptions.h

@galabovaa galabovaa requested a review from jajhall June 4, 2025 11:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (0bfb4cc) to head (d96f16c).
Report is 6 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2387      +/-   ##
==========================================
- Coverage   79.11%   79.11%   -0.01%     
==========================================
  Files         346      346              
  Lines       84952    84910      -42     
==========================================
- Hits        67212    67173      -39     
+ Misses      17740    17737       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

I've checked it locally

I did wonder about having a test to verify that this facility isn't broken in future. I guess that we have some "command line" CI tests to which is could be added

@galabovaa galabovaa merged commit b9c3273 into latest Jun 4, 2025
304 of 305 checks passed
@galabovaa galabovaa deleted the cli-fix-spaces branch June 23, 2025 20:17
jajhall pushed a commit that referenced this pull request Feb 10, 2026
jajhall added a commit that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants