Skip to content

Speed up dominated columns reduction#2639

Merged
jajhall merged 5 commits intoERGO-Code:latestfrom
fwesselm:speedUpDomColRed
Nov 9, 2025
Merged

Speed up dominated columns reduction#2639
jajhall merged 5 commits intoERGO-Code:latestfrom
fwesselm:speedUpDomColRed

Conversation

@fwesselm
Copy link
Copy Markdown
Collaborator

@fwesselm fwesselm commented Nov 6, 2025

  • This PR speeds up the dominated columns reduction (HPresolve::dominatedColumns) for models with many columns.
  • Testing on 850+ MIPs did not reveal any regressions. Only 13 models are affected by these code changes and the ratio between the shifted geometric means of the running times is 1.0, so (average) performance is not affected.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.11%. Comparing base (f6c3703) to head (384b9af).
⚠️ Report is 15 commits behind head on latest.

Files with missing lines Patch % Lines
highs/presolve/HPresolve.cpp 89.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2639      +/-   ##
==========================================
+ Coverage   81.08%   81.11%   +0.02%     
==========================================
  Files         349      349              
  Lines       85328    85466     +138     
==========================================
+ Hits        69191    69325     +134     
- Misses      16137    16141       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa galabovaa requested a review from jajhall November 6, 2025 18:20
Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, thanks @fwesselm

@jajhall jajhall merged commit 6bba1c5 into ERGO-Code:latest Nov 9, 2025
254 of 255 checks passed
@fwesselm fwesselm deleted the speedUpDomColRed branch November 11, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants