Merged
Conversation
…ntroduced HighsIis::irreducible_
…cible not set. Added unit tests that are failing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2644 +/- ##
=======================================
Coverage 81.22% 81.22%
=======================================
Files 349 349
Lines 85780 85780
=======================================
Hits 69676 69676
Misses 16104 16104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing IIS facility has been refactored and is much more robust. Rather than have
HighsOption::iis_strategybe one from an enum of "strategy scenarios" it is now a bit mapHighs::getIisis calledHence, by just setting the 2-bit, an IS is formed reliably, and at not great expense (for an LP)
Enhancements to be added in due course
Clearly if the relaxation of a MIP is infeasible, an IIS is found very much more cheaply. Indeed, it makes sense to test whether the relaxation is infeasible before attempting to find even an IS of a MIP.