mip: Fix use-after-move in HighsLpRelaxation::loadModel#2713
Merged
jajhall merged 1 commit intoERGO-Code:latestfrom Dec 26, 2025
Merged
mip: Fix use-after-move in HighsLpRelaxation::loadModel#2713jajhall merged 1 commit intoERGO-Code:latestfrom
jajhall merged 1 commit intoERGO-Code:latestfrom
Conversation
Save lpmodel.num_col_ before passing lpmodel via std::move to lpsolver.passModel(). After the move, lpmodel is in a valid but unspecified state, making access to its members undefined behavior. Found by Coverity static analysis.
Contributor
Author
|
The was uncovered during a Coverity scan on scipy: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2713 +/- ##
==========================================
+ Coverage 81.06% 81.33% +0.26%
==========================================
Files 347 349 +2
Lines 85219 86135 +916
==========================================
+ Hits 69083 70054 +971
+ Misses 16136 16081 -55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajhall
approved these changes
Dec 26, 2025
Member
jajhall
left a comment
There was a problem hiding this comment.
This isn't known to have caused any problems, bit it does no harm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save lpmodel.num_col_ before passing lpmodel via std::move to lpsolver.passModel(). After the move, lpmodel is in a valid but unspecified state, making access to its members undefined behavior.
Found by Coverity static analysis.