BUG: initialize save_value field to fix uninitialized memory use#2747
Merged
jajhall merged 1 commit intoERGO-Code:latestfrom Jan 14, 2026
Merged
BUG: initialize save_value field to fix uninitialized memory use#2747jajhall merged 1 commit intoERGO-Code:latestfrom
jajhall merged 1 commit intoERGO-Code:latestfrom
Conversation
When a HighsSimplexBadBasisChangeRecord is created, save_value is not set until later in applyTabooRowOut/applyTabooVariableIn. Pushing the struct with an uninitialized field copies garbage memory. Found via Coverity static analysis
Contributor
Author
|
Coverity message: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a HighsSimplexBadBasisChangeRecord is created, save_value is not set until later in applyTabooRowOut/applyTabooVariableIn. Pushing the struct with an uninitialized field copies garbage memory.
Found via Coverity static analysis