Skip to content

Hipo QP solver#2854

Merged
jajhall merged 63 commits intolatestfrom
hipo-qp
Feb 16, 2026
Merged

Hipo QP solver#2854
jajhall merged 63 commits intolatestfrom
hipo-qp

Conversation

@filikat
Copy link
Copy Markdown
Collaborator

@filikat filikat commented Feb 15, 2026

  • Added logic to solve QPs with HiPO.
  • Introduced a new solver option "qpasm", which is the default QP solver for now. Selecting "hipo" or "ipm" instead uses HiPO.
  • The HiPO preprocessor has been refactored and made more powerful, since HiGHS does not have presolve for QPs.
  • The tests in TestQpSolver.cpp now run both with qpasm and hipo.
  • Since now there are options to choose both LP and QP solvers, give a warning if the selected solver is not compatible with the type of the problem, and ignore the option.
  • Added some functions to HighHessian to access its diagonal and do matrix-vector products.
  • Introduced some logic to better detect stagnation for problems that would otherwise keep iterating forever.
  • Fixed an assertion in HighsSparseMatrix.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2026

Codecov Report

❌ Patch coverage is 90.39301% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.32%. Comparing base (bec3258) to head (0355bdb).
⚠️ Report is 134 commits behind head on latest.

Files with missing lines Patch % Lines
highs/lp_data/Highs.cpp 79.43% 22 Missing ⚠️
highs/model/HighsHessian.cpp 0.00% 20 Missing ⚠️
check/TestQpSolver.cpp 99.68% 1 Missing ⚠️
highs/lp_data/HighsOptions.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2854      +/-   ##
==========================================
+ Coverage   80.28%   80.32%   +0.04%     
==========================================
  Files         348      348              
  Lines       86212    86386     +174     
==========================================
+ Hits        69211    69386     +175     
+ Misses      17001    17000       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@filikat filikat marked this pull request as ready for review February 16, 2026 10:23
@filikat filikat requested a review from jajhall February 16, 2026 10:23
Copy link
Copy Markdown
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to assess all the changes, as (understandably) plenty of QPASM code has been moved/indented, but I trust you

I'll now see what happens if I merge in fix-2781 and fix-2821

@jajhall jajhall merged commit ee68c0e into latest Feb 16, 2026
438 of 441 checks passed
@jajhall
Copy link
Copy Markdown
Member

jajhall commented Feb 16, 2026

Please update FEATURES.md with respect to this PR, @filikat Just update latest...

@jajhall
Copy link
Copy Markdown
Member

jajhall commented Feb 16, 2026

I'll now see what happens if I merge in fix-2781 and fix-2821

Not as bad as I feared! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants