Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2934 +/- ##
==========================================
- Coverage 81.54% 81.22% -0.33%
==========================================
Files 347 358 +11
Lines 86942 88576 +1634
==========================================
+ Hits 70901 71943 +1042
- Misses 16041 16633 +592 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajhall
left a comment
There was a problem hiding this comment.
So, you're doing ten rounds of scaling, and then moving the factors to the nearest power-of-2. Maybe they should be moved to the nearest power-of-2 after each scaling round, so that convergence is "over the allowable values"
Otherwise, this looks fine
|
I thought about this, but the results are actually a bit worse that way. |
Fair point |
This PR changes the scaling to infinity-norm equilibration of the rows and columns of the matrix. The scaling procedure takes into account also the magnitude of the diagonal of matrix Q and the width of the bounds interval.
Changing the scaling significantly reduces the number of iterations on some instances, including some of the PyPSA problems, and improves robustness in general.