Removed redundant 'use' statements that slowed the Intel build #57
+7
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Intel compiler has been taking a long time to build glide_io.F90.
Some testing showed that this is because 'use glide_types' and three other use statements
were repeated in each of a large number of accessor subroutines.
For some reason, this hasn't been an issue on the Gnu compiler.
I modified ../utils/generate_ncvars.py and ../libglimmer/ncdf_template.in
so that these 'use' statements appear only at the top of the glide_io module.
With this change, the Intel build time on derecho with 8 cores ('make -j 8')
decreases from about 4:40 to 1:10, a welcome improvement.
TimvandenAkker
pushed a commit
that referenced
this pull request
Jan 22, 2025
Removed redundant 'use' statements that slowed the Intel build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bill Lipscomb says: "The Intel compiler has been taking a long time to build glide_io.F90. Some testing showed that this is because 'use glide_types' and three other use statements were repeated in each of a large number of accessor subroutines. For some reason, this hasn't been an issue on the Gnu compiler.
I modified ../utils/generate_ncvars.py and ../libglimmer/ncdf_template.in so that these 'use' statements appear only at the top of the glide_io module.
With this change, the Intel build time on derecho with 8 cores ('make -j 8') decreases from about 4:40 to 1:10, a welcome improvement."