-
Notifications
You must be signed in to change notification settings - Fork 18
Add glomap/UKCA dust mode variables #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * `real(kind=kind_phys)`: units = kg kg-1 | ||
| * `number_fraction_of_coarse_aerosol_particles_in_air`: Number fraction of coarse mode dust aerosol particles | ||
| * `real(kind=kind_phys)`: units = 1 | ||
| * `number_fraction_of_accumulation_aerosol_particles_in_air`: Number fraction of accumulation mode dust aerosol particles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "accumulation" or "accumulated"? Same for 456 and then in the other file, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 dust modes in UKCA/GLOMAP - coarse mode and accumulation mode. So 'accumulation' refers to this mode. That's my understanding but I can double check again with model experts if you feel strongly it should be accumulated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just curious, but if the mode is called "accumulation" then that is fine with me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI To be on the safe side I just double-checked with one of the scientists working on glomap and they said that accumulation is the right term for the mode.
gold2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues
ss421
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou for the addition.
|
I wish I was added during the review. Change this: To this as I believe the number fraction here is the same as a mole fraction but brings more clarity of what this fraction really is: |
|
Alternatively, if |
Hi Jerome, now that we have a std names governance team, it's up to your organization's representative to inform people about changes and adding them as reviewers. |
Sorry @jeromebarre @climbfuji , I guess I dropped the ball on this. Still learning my responsibilities as part of the governance team since I just started. |
|
@jeromebarre I'm on annual leave until 2 June now but will address this when I get back. |
|
I will set up a new PR to make the change you requested @jeromebarre. Do you have a preference for mole_fraction with mol mol-1 units or number_fraction with particles particles-1 units? If not I might just go for the latter. It seems like they are numerically the same anyway. |
add glomap dust modes (ESCOMP#111) This PR adds in new aerosol variables needed for the Met Office LFRIC forecast model. These are the number and mass fractions for the two dust modes in the UKCA/GLOMAP aerosol model.
This PR adds in new aerosol variables needed for the Met Office LFRIC forecast model. These are the number and mass fractions for the two dust modes in the UKCA/GLOMAP aerosol model.