Skip to content

Update testlist_rtm#55

Merged
slevis-lmwg merged 4 commits intoESCOMP:masterfrom
slevis-lmwg:upd_testlist_rtm
Nov 8, 2024
Merged

Update testlist_rtm#55
slevis-lmwg merged 4 commits intoESCOMP:masterfrom
slevis-lmwg:upd_testlist_rtm

Conversation

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 31, 2024

As recommended by @ekluzek

Resolves #54

@slevis-lmwg slevis-lmwg self-assigned this Oct 31, 2024
@slevis-lmwg slevis-lmwg requested a review from ekluzek October 31, 2024 23:16
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 31, 2024

Generating baselines on derecho:
./run_sys_tests -s rtm -c rtm1_0_80-ctsm5.2.029 -g rtm1_0_80-ctsm5.3.009

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Nov 6, 2024

Comparing to baselines on derecho:
./run_sys_tests -s rtm -g rtm1_0_81-ctsm5.2.009 -c rtm1_0_80-ctsm5.3.009
/glade/work/slevis/git/hXi_hXa_tapes_iss1059/tests_1106-151907de

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Nov 6, 2024

When rtm test suite completes, make tag and merge

@slevis-lmwg
Copy link
Contributor Author

@ekluzek most tests failed with the following errors:

ERROR: Invalid compset name, I1850Clm45Sp, all stub components generated
ERROR: Invalid compset name, I2000Clm60SpNoAnthro, all stub components generated

The first could be replaced with one of these:

I1850Clm45BgcCrop
I1850Clm45BgcCru
I1850Clm45Bgc

The second could be replaced with one of these (though I assume the Rs is no good for running rtm):

I2000Clm60Sp
I2000Clm60SpRs

I will try the 3rd from the first list and the 1st from the second list, and I will resubmit the test suite.

@slevis-lmwg
Copy link
Contributor Author

Rethinking the above choices to:
I2000Clm45Sp
I1850Clm60SpNoAnthro

@slevis-lmwg
Copy link
Contributor Author

New problem with the NoAnthro compset:
err=ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for fsurdat.

Removed NoAnthro and got next error:
ERROR: No variable RTM_FLOOD_MODE found in case

@ekluzek we probably need to discuss what we want here before I go down a rabbit hole to resolve this.

@slevis-lmwg
Copy link
Contributor Author

From meeting with @ekluzek
Change the NoAnthro tests to f09.

@slevis-lmwg
Copy link
Contributor Author

New tests
IN PROGRESS ./run_sys_tests -s rtm -g rtm1_0_81-ctsm5.2.009 -c rtm1_0_80-ctsm5.3.009
in /glade/derecho/scratch/slevis/tests_1108-140627de

@slevis-lmwg
Copy link
Contributor Author

@jedwards4b this PR changes tests in the rtm testlist. I ran the rtm test-suite and they work. Would you be willing to approve my PR?

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@slevis-lmwg slevis-lmwg merged commit 658cb73 into ESCOMP:master Nov 8, 2024
@slevis-lmwg slevis-lmwg deleted the upd_testlist_rtm branch November 8, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the compsets being tested in our RTM testlists

2 participants