restart pointer filenames now have the simulation time-stamp in them#57
Merged
ekluzek merged 10 commits intoESCOMP:masterfrom Jan 4, 2025
Merged
restart pointer filenames now have the simulation time-stamp in them#57ekluzek merged 10 commits intoESCOMP:masterfrom
ekluzek merged 10 commits intoESCOMP:masterfrom
Conversation
…estamp in the filename and get it to compile and run on Derecho for the ERS_D_Ld5.f10_f10_mg37.I2000Clm50SpRtmFl.derecho_intel.rtm-default test
slevis-lmwg
approved these changes
Jan 3, 2025
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
Thank you @ekluzek, this looks good to me from a somewhat quick look. I would not mind meeting with you for a more detailed look if you think it's a good idea.
Contributor
Author
|
OK, I've git an ERS test working now. So sent off the rtm test suite (which is only Derecho). So we'll see how that does. |
ekluzek
commented
Jan 3, 2025
ekluzek
commented
Jan 3, 2025
ekluzek
commented
Jan 3, 2025
slevis-lmwg
added a commit
to samsrabin/RTM
that referenced
this pull request
Jan 15, 2025
The RTM rpointer file now has the simulation timestamp in the filename Have the restart pointer filenames for RTM with the simulation time-stamp in them. Make it backwards compatible to using filenames without the simulation time-stamp as well. This changes time-manager setup from reading in the restart time from the restart file -- to using the current time sent from the coupler. Previously you would EITHER call timemgr_init OR timemgr_restart. Now, you always call timemgr_init -- and only call timemgr_restart for a restart case, with most of what it does is to make sure the time on the restart file agrees with the time sent from the coupler. Also remove use of shr_file_mod throughout the code. Change the ChangeLog file into a markdown file and start using some markdown syntax. Resolves: ESCOMP#53 Resolves: ESCOMP#46 PR ESCOMP#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have the restart pointer filenames for RTM with the simulation time-stamp in them. Make it backwards compatible to using filenames without the simulation time-stamp as well. This changes time-manager setup from reading in the restart time from the restart file -- to using the current time sent from the coupler. Previously you would EITHER call timemgr_init OR timemgr_restart. Now, you always call timemgr_init -- and only call timemgr_restart for a restart case, with most of what it does is to make sure the time on the restart file agrees with the time sent from the coupler.
Fixes #53
Fixes #46