Allow for CMOR checks but DO NOT raise exceptions (at the user's risk!)

[valeriupredoi]

Not good, guys, not good - analyses that need to go through past nit-picky CMOR exceptions still stumble at them and return exceptions with the tool stopping. I thought the whole point of cmor_strict: false was to bypass all these roadblocks 🍺 Running an IPCC stuff for @LisaBock and am getting pestered by height2m not present. Who cares about bloody height2m? 😠

[mattiarighi]

Which recipe are you trying?
Is it due to the recent merge of #305?

[valeriupredoi]

recipe_ipccwg1ar6ch3_highres

[mattiarighi]

Can you try a few another ones to see whether it is a general issue or specific to that recipe?

[schlunma]

I think cmor_strict does not affect any CMOR check, it only affects variable reading, for example allowing the use of the custom tables (at first I also thought it would allow the skipping of some tests, but it doesn't).

[valeriupredoi]

check_metadata() has no provision of not raising CMORCheckError (fail_on_error set to False will eventually raise it at the end anyway), it's a fundamental problem with our CMOR issues handling not an issue resulting from a PR, man 🍺

[valeriupredoi]

yep, @schlunma is correct - I want the check to find the issues, fix as many as possible but don't die on me if it couldn't fix everything, just report them and march on. Something like the flag in #307 that if set, it should go on at the user's risk, but go on until it hits rock bottom (or not)

[valeriupredoi]

...which in my case, it went on and finished the bloody recipe no problemo, without any height2m, coz that's just like Brexit, nobody needs it but it's there for some reason 😁

[bouweandela]

If you want no CMOR checks (see also #88), you can disable them in the recipe by making sure that every preprocessor contains:

fix_metadata: {cmor_table: null}
fix_data: {cmor_table: null}
cmor_check_metadata: false
cmor_check_data: false

However, if you're missing a 2m height coordinate for a dataset I would recommend implementing a fix for it, this shouldn't be much work.

Note however that many preprocessor functions and diagnostic scripts depend on the data being in the format specified by the CMOR standard, so disabling the checks is not recommended.