Extend preprocessor multi_model_statistics to handle data with "altitude" coordinate#1010
Merged
axel-lauer merged 2 commits intomasterfrom Feb 19, 2021
Merged
Extend preprocessor multi_model_statistics to handle data with "altitude" coordinate#1010axel-lauer merged 2 commits intomasterfrom
axel-lauer merged 2 commits intomasterfrom
Conversation
schlunma
reviewed
Feb 19, 2021
Contributor
schlunma
left a comment
There was a problem hiding this comment.
One small suggestion attached. Tested successfully with real data 👍
This is only a temporary solution, but since the multi_model_statistics preprocessor will be lazy soon and hopefully support arbitrary input dimensions (#968), I guess we can merge this small workaround as is.
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
schlunma
approved these changes
Feb 19, 2021
Contributor
There was a problem hiding this comment.
nice one @axel-lauer - please add relevant review labels next time, gonna add the passed tech review now - nevermind, we don't have them in Core 👍
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the preprocessor multi_model_statistics to allow handling of data with a vertical corrdinate "altitude".
Before you get started
Checklist
pre-commitoryamllintchecksIf you make backwards incompatible changes to the recipe format:
To help with the number pull requests: