Added additional test cases for integration tests of data_finder.py#1087
Merged
valeriupredoi merged 2 commits intomasterfrom May 10, 2021
Merged
Added additional test cases for integration tests of data_finder.py#1087valeriupredoi merged 2 commits intomasterfrom
valeriupredoi merged 2 commits intomasterfrom
Conversation
valeriupredoi
approved these changes
May 10, 2021
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
cheers @schlunma - we should start thinking about breaking up these monster yaml configs into smaller, more manageable bits at some point, not now 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional test cases for the integration tests of
_data_finder.pywhich should make the review of #1082 easier.Closes #1085.
There are no changes in the code itself, so I think we can merge this quickly. What do you think @valeriupredoi ?
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: