Merged
Conversation
schlunma
changed the title
Member
|
@jvegasbsc Would you have time to review this? |
valeriupredoi
approved these changes
May 10, 2021
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
very nice, thanks a lot @schlunma 🍺
| def concatenate(cubes): | ||
| """Concatenate all cubes after fixing metadata.""" | ||
| if not cubes: | ||
| return cubes |
Contributor
There was a problem hiding this comment.
thank you! I meant to plug this in since January 😆
Contributor
|
this is good, @jvegasbsc have a look too pls mate but it's good to go by me 👍 |
remi-kazeroni
approved these changes
May 11, 2021
Contributor
remi-kazeroni
left a comment
remi-kazeroni
left a comment
There was a problem hiding this comment.
Works fine for me! This PR solves the issues I had with the --skip-nonexistent option. Thanks a lot for your work @schlunma 👍
Contributor
|
oops I merged 😁 @jvegasbsc holler back if you encounter any issues, mate, but this is working well and I am rather happy to see it in the sooner than later 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was introduced in #917 that prevented the usage of the
--skip-nonexistentoption. I also add a tiny test for it.Note that I also adapted the preprocessors
concatenateandsavewhich gave ugly error messages when an empty cube was passed. This should never happen during a regular ESMValTool run, but could happen when these functions are used as part of theesmvalcoreAPI.Closes #1040, closes #988.
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: