Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 188 188
Lines 9150 9150
=======================================
Hits 7827 7827
Misses 1323 1323 Continue to review full report at Codecov.
|
Contributor
Author
|
@bouweandela @zklaus we should talk about this at the meeting tomorrow 👍 |
This was referenced Jun 30, 2021
|
Agree with the idea, have not yet checked the implementation. |
Contributor
Author
|
cool! have a look when you gots time 👍 |
|
Will do once we decide to go ahead with this. 🍻 |
Contributor
Author
bouweandela
approved these changes
Jul 30, 2021
Member
bouweandela
left a comment
There was a problem hiding this comment.
The conda build is taking too long, but it looks unrelated to this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1199
Related to full functionality of #1182
Tests failing due to problem fixed in #1197
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: