Removed custom version of AtmosphereSigmaFactory#1382
Merged
Conversation
This was referenced Nov 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
+ Coverage 88.39% 88.61% +0.22%
==========================================
Files 195 195
Lines 9958 9867 -91
==========================================
- Hits 8802 8744 -58
+ Misses 1156 1123 -33
Continue to review full report at Codecov.
|
remi-kazeroni
approved these changes
Nov 3, 2021
Contributor
remi-kazeroni
left a comment
remi-kazeroni
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for taking care of this @schlunma!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
iris 3.1 added support for
AtmosphereSigmaFactory(SciTools/iris#4052). For this reason we can remove our custom version of it.Closes #1380 (Needs also changes in ESMValTool)
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: