Added tests for input/output filenames for ICON and EMAC on-the-fly CMORizer

[schlunma]

Description

While coding for #1678 I realized that we currently don't have any tests for input file names/input directories/output files for the EMAC and ICON on-the-fly CMORizers. This PR adds those. In additon, I slightly adapted the output file name for EMAC to make it consistent with CMIP data.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

Merging #1718 (cb70031) into main (62b5c30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         206      206           
  Lines       11204    11204           
=======================================
  Hits        10249    10249           
  Misses        955      955           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[schlunma]

@valeriupredoi would you have time to briefly look at this? Thanks so much!!

[valeriupredoi]

@schlunma cheers, yeps - will do today, in a jiffy!

[valeriupredoi]

looking good, cheers Manu! One question related to the native file names (sorry, first time I sees them), and another question - do we have true negative tests? ie a group of files that should not be found - I can't remember if I implemented that initially, so if there are none for CMIP data that's fine, we can leave it like that

[schlunma]

This also has negative tests:

available_files:
      - amip/Amon/amip___________200001_Amon.nc
      - amip/Amon/amip___________200002_Amon.nc
      - amip/Amon/amip___________200003_Amon.nc
      - amip/Amon/amip___________200001_Amon-p-mm.nc
      - amip/Amon/amip___________200002_Amon-p-mm.nc
      - amip/Amon/amip___________200003_Amon-p-mm.nc
      - amip/rad/amip___________200001_rad.nc
      - amip/rad/amip___________200002_rad.nc
      - amip/rad/amip___________200003_rad.nc
      - amip/rad/amip___________200001_rad-p-mm.nc
      - amip/rad/amip___________200002_rad-p-mm.nc
      - amip/rad/amip___________200003_rad-p-mm.nc
    dirs:
      - amip/Amon
    file_patterns:
      - amip*Amon.nc
    found_files:
      - amip/Amon/amip___________200002_Amon.nc
      - amip/Amon/amip___________200003_Amon.nc

As you can see, only a subset of the files available is supposed to be found.

[valeriupredoi]

This also has negative tests:

available_files:
      - amip/Amon/amip___________200001_Amon.nc
      - amip/Amon/amip___________200002_Amon.nc
      - amip/Amon/amip___________200003_Amon.nc
      - amip/Amon/amip___________200001_Amon-p-mm.nc
      - amip/Amon/amip___________200002_Amon-p-mm.nc
      - amip/Amon/amip___________200003_Amon-p-mm.nc
      - amip/rad/amip___________200001_rad.nc
      - amip/rad/amip___________200002_rad.nc
      - amip/rad/amip___________200003_rad.nc
      - amip/rad/amip___________200001_rad-p-mm.nc
      - amip/rad/amip___________200002_rad-p-mm.nc
      - amip/rad/amip___________200003_rad-p-mm.nc
    dirs:
      - amip/Amon
    file_patterns:
      - amip*Amon.nc
    found_files:
      - amip/Amon/amip___________200002_Amon.nc
      - amip/Amon/amip___________200003_Amon.nc

As you can see, only a subset of the files available is supposed to be found.

gotcha! Too Monday morning for me to catch that - good stuff! All fine by me then, cheers for the good work bud! 🍺

[schlunma]

Thanks for the quick review 🎉