add siconc fixes for EC-Earth3-Veg and EC-Earth3-Veg-LR models

[egalytska]

Description

Introduced fixes for siconc variable in EC-Earth3-Veg and EC-Earth3-Veg-LR models while concatenating historical and SSP5-8.5 simulations.
Closes #1731

Link to documentation:

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[egalytska]

Hi @bsolino and @remi-kazeroni , could u please have a brief look when u have some time?

[remi-kazeroni]

Hi @bsolino and @remi-kazeroni , could u please have a brief look when u have some time?

Hi @egalytska, yes I will try to look at this PR this week to help you with the test and formatting issues. In the meantime, could you please merge the main branch into this one? Could you also convert this PR to draft (see the link below the list of reviewers)? We will mark it as ready for review once the checks are all green. Thanks!

[egalytska]

@remi-kazeroni done and thanks

[codecov]

Codecov Report

Merging #1771 (7fcaf0e) into main (89fbe93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1771   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         202      203    +1     
  Lines       10908    10918   +10     
=======================================
+ Hits         9982     9992   +10     
  Misses        926      926           

Impacted Files	Coverage Δ
esmvalcore/cmor/_fixes/cmip6/ec_earth3_veg.py	100.00% <100.00%> (ø)
esmvalcore/cmor/_fixes/cmip6/ec_earth3_veg_lr.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[remi-kazeroni]

Thanks for your contribution @egalytska! 👍 The fixes work fine for me locally. I have fixed a formatting issue and added tests. The PR is now ready for review.

@valeriupredoi, @zklaus: Could one of you do a review of this PR? Thanks 🍻

[egalytska]

Awesome, as usual, thanks @remi-kazeroni

[remi-kazeroni]

Thanks for the review @sloosvel!

@ESMValGroup/technical-lead-development-team, could someone do a final check and merge? Thanks!

[schlunma]

Awesome, thanks all!