Fix mistake in the documentation of esmvalcore.esgf.find_files#1784
Merged
valeriupredoi merged 2 commits intomainfrom Nov 10, 2022
Merged
Fix mistake in the documentation of esmvalcore.esgf.find_files#1784valeriupredoi merged 2 commits intomainfrom
esmvalcore.esgf.find_files#1784valeriupredoi merged 2 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1784 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 203 203
Lines 10908 10908
=======================================
Hits 9939 9939
Misses 969 969
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlunma
approved these changes
Nov 8, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Looks good, thanks Bouwe!
Member
Author
|
Thanks for the review @schlunma! @ESMValGroup/technical-lead-development-team Could one of you please do a final check and then merge? |
Contributor
|
I shallz! |
valeriupredoi
approved these changes
Nov 10, 2022
Contributor
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
noice, cheers guys!
Contributor
|
@bouweandela @schlunma and myself get the prize for the best PR that causes all tests to fail after merge, when only docs changed 🤣 🤣 https://github.com/ESMValGroup/ESMValCore/actions/runs/3437374771/jobs/5732045770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a mistake in the docstring of
esmvalcore.esgf.find_files. The function is calledsearchin the docstring, where it should befind_files. This pull request corrects the issue.Link to documentation: https://esmvaltool--1784.org.readthedocs.build/projects/ESMValCore/en/1784/api/esmvalcore.esgf.html#esmvalcore.esgf.find_files
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: